New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling mutating "true" -> "false" in TrueValue mutator for in_array/array_search #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maks-rafalko
changed the title
Disabling mutating "true" -> "false" in TrueValue mutator. Add settings for mutators
Disabling mutating "true" -> "false" in TrueValue mutator for in_array/array_search
Jan 5, 2019
localheinz
reviewed
Jan 5, 2019
BackEndTea
requested changes
Jan 5, 2019
maks-rafalko
force-pushed
the
mutator-settings
branch
from
January 5, 2019 20:14
9b03fcd
to
2939c07
Compare
sanmai
reviewed
Jan 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks sensible to me.
BackEndTea
reviewed
Jan 11, 2019
…alse" in in_array and array_search functions. Add json schema validation for TrueValue mutator in infection.json
…ts, fix review comments
…d to Mutator class
maks-rafalko
force-pushed
the
mutator-settings
branch
from
January 11, 2019 20:21
2939c07
to
772d762
Compare
@BackEndTea could you please review again? |
thank you @BackEndTea @sanmai @localheinz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
TrueValue
mutator will no longer mutatetrue
tofalse
forin_array
andarray_search
functions. This can be explicitly enabled in settings.Also, add json schema validation for
TrueValue
mutator ininfection.json
.Fixes #578
Fixes #206