Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow using Infection with Codeception < 3.1.1 #867

Merged
merged 1 commit into from Nov 28, 2019

Conversation

maks-rafalko
Copy link
Member

@maks-rafalko maks-rafalko commented Nov 28, 2019

This one and ready to go.

When Test Framework adapters will be extracted to own composer packages, this will be just in infection/codeception-adapter's composer.json:

{
    "conflicts": {
        "codeception/codeception": "<3.1.1"
    }
}

Now, we can't do it in the root's composer.json, because one can use Infection with e.g. PHPSpec while having Codeception installed as well.

@maks-rafalko maks-rafalko added this to the 0.15.0 milestone Nov 28, 2019
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Infection. We noticed you didn't add any tests. Could you please add them to make sure everything works as expected?

@maks-rafalko maks-rafalko merged commit 73bb17a into master Nov 28, 2019
@maks-rafalko maks-rafalko deleted the feature/forbid-codeception-311 branch November 28, 2019 20:22
@maks-rafalko
Copy link
Member Author

Thank you @sidz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants