Added version number to ASCII banner #809

Bilge · 2019-10-18T08:08:52Z

Closes #808.

tests-checker

Thank you for contributing to Infection. We noticed you didn't add any tests. Could you please add them to make sure everything works as expected?

maks-rafalko · 2019-10-18T08:21:19Z

Can I suggest moving it one line below?

It looks prettier IMO, see

     ____      ____          __  _
    /  _/___  / __/__  _____/ /_(_)___  ____
    / // __ \/ /_/ _ \/ ___/ __/ / __ \/ __ \
  _/ // / / / __/  __/ /__/ /_/ / /_/ / / / /
 /___/_/ /_/_/  \___/\___/\__/_/\____/_/ /_/  0.14.0
 
     ____      ____          __  _
    /  _/___  / __/__  _____/ /_(_)___  ____
    / // __ \/ /_/ _ \/ ___/ __/ / __ \/ __ \
  _/ // / / / __/  __/ /__/ /_/ / /_/ / / / / 0.14.0
 /___/_/ /_/_/  \___/\___/\__/_/\____/_/ /_/

definitely need another pair of eyes @infection/core

theofidry · 2019-10-18T09:18:54Z

I would prefer to stick to the Composer way there tbh:

   ______
  / ____/___  ____ ___  ____  ____  ________  _____
 / /   / __ \/ __ `__ \/ __ \/ __ \/ ___/ _ \/ ___/
/ /___/ /_/ / / / / / / /_/ / /_/ (__  )  __/ /
\____/\____/_/ /_/ /_/ .___/\____/____/\___/_/
                    /_/
Composer version 1.8.6 2019-06-11 15:03:05

Did the same in Box btw in case you are looking for an easier way to copy it: https://github.com/humbug/box/blob/master/src/Console/Application.php

BackEndTea · 2019-10-18T11:59:48Z

I think i'd prefer it below, like @theofidry suggests

Bilge · 2019-10-18T16:35:54Z

OK, but do you just want the bare version number or do you want some decoration like, "Infection version x.y.z"?

Bilge · 2019-10-18T16:58:27Z

Now looks something like

         ____      ____          __  _
        /  _/___  / __/__  _____/ /_(_)___  ____
        / // __ \/ /_/ _ \/ ___/ __/ / __ \/ __ \
      _/ // / / / __/  __/ /__/ /_/ / /_/ / / / / 
     /___/_/ /_/_/  \___/\___/\__/_/\____/_/ /_/

Infection - PHP Mutation Testing Framework dev-master@2c915a4aa2c2b96a9ca2282254aebe8f7af29489

src/Console/Application.php

Remove blank line after version output.

maks-rafalko

Now it's much better :)

Found a small issue when I run bin/infection -V

bin/infection -V

    ____      ____          __  _
   /  _/___  / __/__  _____/ /_(_)___  ____
   / // __ \/ /_/ _ \/ ___/ __/ / __ \/ __ \
 _/ // / / / __/  __/ /__/ /_/ / /_/ / / / /
/___/_/ /_/_/  \___/\___/\__/_/\____/_/ /_/

Infection - PHP Mutation Testing Framework dev-master@a1eb3df1012a2c86c0c32de9503e03140b1b7e9d
Infection - PHP Mutation Testing Framework dev-master@a1eb3df1012a2c86c0c32de9503e03140b1b7e9d

duplicated message

maks-rafalko · 2019-11-03T07:11:25Z

src/Console/Application.php


        return parent::doRun($input, $output);
    }

-    public function getLongVersion()


Why did we remove it?

I guess now it returns Infection - PHP Mutation Testing Framework dev-master@a1eb3df1012a2c86c0c32de9503e03140b1b7e9d instead of Infection - PHP Mutation Testing Framework dev-master?

It was removed because it wasn't used. Or didn't seem to do anything useful. I don't exactly remember now 😂

Bilge · 2019-11-15T22:22:08Z

What should happen when calling -V? Should it still output the ASCII banner or just the version number?

Changed version command output to exclude ASCII banner.

Bilge · 2019-11-15T22:32:57Z

I changed the version command (--version/-V) to no longer show the ASCII banner. It is still shown for all other commands. My reasoning is that whether people wish to visually parse the version with their eyes or machine parse the version programmatically, they don't want to deal with the ASCII spam in either case. However, it still emits debug warning lines, which may also interfere with naive parsing.

I would suggest not emitting the debug warning with the version (-V) command or outputting it on STDERR rather than STDOUT to make it easier to filter, but probably either solution is out of scope for this particular PR.

maks-rafalko · 2019-11-20T07:03:41Z

Sorry for the delay with review.

I'm quite happy with the result. Just 1 question: do we need that long hash in a version? Please compare

# before
Infection - PHP Mutation Testing Framework dev-version

# after
Infection - PHP Mutation Testing Framework dev-version@36f7fe04eca492c12ed5af23a4049c26214447f4

--

I agree, there is no point to display ascii logo with -V | --version

maks-rafalko

Please, fix the builds (make cs)

Bilge · 2019-11-20T14:48:16Z

I presume the long hash is only displayed when the version isn't tagged. Most people would use a release version and thus never see it, and for those not using a tag it is probably useful to see the hash.

theofidry · 2019-11-20T16:10:49Z

I would display the hash in any case, since sometimes a tag is not enough, but only showing the 8 first characters is enough, no need for more.

maks-rafalko

I've restarted a couple of builds, fails are unrelated.

Looks good to me.

Bilge · 2019-11-21T08:55:09Z

I think this should be merged to 0.13 and 0.14 branches also, so people using older versions can actually see that they are.

maks-rafalko · 2019-11-21T08:56:55Z

We don't support 0.13 anymore. If you want this to be in the patch 0.14.x release, please retarget this PR to 0.14 branch.

Bilge · 2019-11-21T09:51:31Z

I want it in both.

…

On Thu, 21 Nov 2019, 08:56 Maks Rafalko, ***@***.***> wrote: We don't support 0.13 anymore. If you want this to be in the patch 0.14.x release, please retarget this PR to 0.14 branch. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#809?email_source=notifications&email_token=AADS4YQRPBDEDBJF5CEQKGLQUZENRA5CNFSM4JCD774KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZORBQ#issuecomment-556984454>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADS4YURN5SSCL34HA735OTQUZENRANCNFSM4JCD774A> .

theofidry · 2019-11-21T10:00:54Z

We just can not afford to maintain multiple branches, it is one of the reasons why Infection is still not in stable release as well. So if you want it on an older version I believe you should fork the project to merge your change there. But I admit I don’t really see the value of keeping to use an old version at this point

…

On Thu 21 Nov 2019 at 10:51, Bilge ***@***.***> wrote: I want it in both. On Thu, 21 Nov 2019, 08:56 Maks Rafalko, ***@***.***> wrote: > We don't support 0.13 anymore. If you want this to be in the patch 0.14.x > release, please retarget this PR to 0.14 branch. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > < #809?email_source=notifications&email_token=AADS4YQRPBDEDBJF5CEQKGLQUZENRA5CNFSM4JCD774KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZORBQ#issuecomment-556984454 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AADS4YURN5SSCL34HA735OTQUZENRANCNFSM4JCD774A > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#809?email_source=notifications&email_token=ABHPVAPQIMVNG5FGIK7V6H3QUZK2JA5CNFSM4JCD774KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZT3TY#issuecomment-557006287>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHPVAII4EPRVCCQ6AUME3DQUZK2JANCNFSM4JCD774A> .

Bilge · 2019-11-21T10:10:10Z

If you support and thus test on older versions of PHP, you will end up with an older version of infection, because infection has already dropped support for them.

…

On Thu, 21 Nov 2019, 10:00 Théo FIDRY, ***@***.***> wrote: We just can not afford to maintain multiple branches, it is one of the reasons why Infection is still not in stable release as well. So if you want it on an older version I believe you should fork the project to merge your change there. But I admit I don’t really see the value of keeping to use an old version at this point On Thu 21 Nov 2019 at 10:51, Bilge ***@***.***> wrote: > I want it in both. > > On Thu, 21 Nov 2019, 08:56 Maks Rafalko, ***@***.***> wrote: > > > We don't support 0.13 anymore. If you want this to be in the patch 0.14.x > > release, please retarget this PR to 0.14 branch. > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > < > #809?email_source=notifications&email_token=AADS4YQRPBDEDBJF5CEQKGLQUZENRA5CNFSM4JCD774KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZORBQ#issuecomment-556984454 > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AADS4YURN5SSCL34HA735OTQUZENRANCNFSM4JCD774A > > > > . > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #809?email_source=notifications&email_token=ABHPVAPQIMVNG5FGIK7V6H3QUZK2JA5CNFSM4JCD774KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZT3TY#issuecomment-557006287 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ABHPVAII4EPRVCCQ6AUME3DQUZK2JANCNFSM4JCD774A > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#809?email_source=notifications&email_token=AADS4YV3XEJJNT3NPP4VEQDQUZL5PA5CNFSM4JCD774KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZUZ3Y#issuecomment-557010159>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADS4YXVDACN2MNGZCNHOW3QUZL5PANCNFSM4JCD774A> .

sanmai · 2019-11-21T10:26:35Z

It makes all kinds of sense to run Infection only under the most recent version of PHP, primarily because of the most recent language features being fully supported, and because it is super easy with Docker.

As for the older versions of PHP, not only they're not very worthy for a CI tool like Infection, but also supporting unlimited number of PHP versions requires unlimited resources, which is unaffordable for any volunteer-maintained project like Infection. Or PHPUnit, for that matter. We already have important PRs in the works for weeks and months, as that's where ours and yours invaluable time and effort will make the most impact.

Bilge · 2019-11-24T20:44:50Z

Nobody is asking anyone to support "unlimited versions". Notwithstanding there are not unlimited versions to begin with, and thus the whole argument is predicated on nonsense, can we just merge this and then I'll backport it to 0.14 in a separate PR.

theofidry · 2019-11-24T23:24:31Z

But what you are requesting is to allow backports to previous versions which means multiple branch supports and management. That it may not look like much work to you is one thing, but really nobody in the team is willing to put extra efforts into this. We are already overwhelmed by the sheer amount of work to do (~50 issues and ~15 PR opened on average at all time).

A good example of this is PHP-CS-Fixer: its support policy is impressive, but the result is a huge slowdown in activity despite a lot of enthusiastic contributions. While it may be annoying for this peculiar case, we ought to draw a line somewhere for our own mental health

maks-rafalko · 2019-11-25T04:39:31Z

Thank you @Bilge.

sanmai · 2019-11-25T07:12:59Z

Regarding a ~~deleted~~ comment on versions and testing: Infection is not a testing tool. If you need to verify that your program is correct as it can be, running tests under an earlier version of PHP should be enough. On the other hand, using Infection to infer quality of your tests under all deployed versions of PHP is a waste of resources since the only the most recent versions of Infection will give you the most accurate result. Earlier versions do not support all the new mutations, and therefore by definition are less accurate.

Running a most recent version of Infection just once in the CI pipeline is enough to tell you everything you need to know about certain quality of your tests.

Bilge · 2019-11-25T08:44:41Z

@sanmai Thanks, that makes sense. Although it requires more effort to limit to only the latest build, it's probably worth doing.

Not sure any comments were deleted?

* Added version number to ASCII banner. * Changed version number to long version. Moved version below logo. * Changed logo to be left-aligned (no margin). Remove blank line after version output. * Fixed version output twice instead of just once when invoked with `-V`. Changed version command output to exclude ASCII banner. * CS fix.

Added version number to ASCII banner.

cb496e1

tests-checker bot suggested changes Oct 18, 2019

View reviewed changes

Changed version number to long version. Moved version below logo.

4d5a4a8

theofidry reviewed Oct 18, 2019

View reviewed changes

src/Console/Application.php Show resolved Hide resolved

maks-rafalko requested changes Oct 31, 2019

View reviewed changes

src/Console/Application.php Show resolved Hide resolved

src/Console/Application.php Show resolved Hide resolved

src/Console/Application.php Outdated Show resolved Hide resolved

Changed logo to be left-aligned (no margin).

56d8bf0

Remove blank line after version output.

maks-rafalko requested changes Nov 3, 2019

View reviewed changes

Fixed version output twice instead of just once when invoked with -V.

36f7fe0

Changed version command output to exclude ASCII banner.

Merge branch 'master' into version

8d3d984

maks-rafalko requested changes Nov 20, 2019

View reviewed changes

maks-rafalko added this to the 0.15.0 milestone Nov 20, 2019

maks-rafalko added DX Developer Experience Enhancement labels Nov 20, 2019

CS fix.

b6f180c

maks-rafalko approved these changes Nov 21, 2019

View reviewed changes

maks-rafalko merged commit 4ba7164 into infection:master Nov 25, 2019

sanmai mentioned this pull request Dec 6, 2019

added php compatibility matrix infection/site#151

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added version number to ASCII banner #809

Added version number to ASCII banner #809

Bilge commented Oct 18, 2019

tests-checker bot left a comment

maks-rafalko commented Oct 18, 2019 •

edited

theofidry commented Oct 18, 2019

BackEndTea commented Oct 18, 2019 •

edited

Bilge commented Oct 18, 2019 •

edited

Bilge commented Oct 18, 2019

maks-rafalko left a comment •

edited

maks-rafalko Nov 3, 2019

Bilge Nov 15, 2019 •

edited

Bilge commented Nov 15, 2019

Bilge commented Nov 15, 2019

maks-rafalko commented Nov 20, 2019

maks-rafalko left a comment

Bilge commented Nov 20, 2019

theofidry commented Nov 20, 2019 •

edited

maks-rafalko left a comment

Bilge commented Nov 21, 2019

maks-rafalko commented Nov 21, 2019

Bilge commented Nov 21, 2019 via email

theofidry commented Nov 21, 2019 via email

Bilge commented Nov 21, 2019 via email

sanmai commented Nov 21, 2019

Bilge commented Nov 24, 2019

theofidry commented Nov 24, 2019 •

edited

maks-rafalko commented Nov 25, 2019

sanmai commented Nov 25, 2019 •

edited

Bilge commented Nov 25, 2019

Added version number to ASCII banner #809

Added version number to ASCII banner #809

Conversation

Bilge commented Oct 18, 2019

tests-checker bot left a comment

Choose a reason for hiding this comment

maks-rafalko commented Oct 18, 2019 • edited

theofidry commented Oct 18, 2019

BackEndTea commented Oct 18, 2019 • edited

Bilge commented Oct 18, 2019 • edited

Bilge commented Oct 18, 2019

maks-rafalko left a comment • edited

Choose a reason for hiding this comment

maks-rafalko Nov 3, 2019

Choose a reason for hiding this comment

Bilge Nov 15, 2019 • edited

Choose a reason for hiding this comment

Bilge commented Nov 15, 2019

Bilge commented Nov 15, 2019

maks-rafalko commented Nov 20, 2019

maks-rafalko left a comment

Choose a reason for hiding this comment

Bilge commented Nov 20, 2019

theofidry commented Nov 20, 2019 • edited

maks-rafalko left a comment

Choose a reason for hiding this comment

Bilge commented Nov 21, 2019

maks-rafalko commented Nov 21, 2019

Bilge commented Nov 21, 2019 via email

theofidry commented Nov 21, 2019 via email

Bilge commented Nov 21, 2019 via email

sanmai commented Nov 21, 2019

Bilge commented Nov 24, 2019

theofidry commented Nov 24, 2019 • edited

maks-rafalko commented Nov 25, 2019

sanmai commented Nov 25, 2019 • edited

Bilge commented Nov 25, 2019

maks-rafalko commented Oct 18, 2019 •

edited

BackEndTea commented Oct 18, 2019 •

edited

Bilge commented Oct 18, 2019 •

edited

maks-rafalko left a comment •

edited

Bilge Nov 15, 2019 •

edited

theofidry commented Nov 20, 2019 •

edited

theofidry commented Nov 24, 2019 •

edited

sanmai commented Nov 25, 2019 •

edited