Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add console output break lines #799

Merged
merged 2 commits into from
Oct 5, 2019
Merged

Add console output break lines #799

merged 2 commits into from
Oct 5, 2019

Conversation

kpn13
Copy link
Contributor

@kpn13 kpn13 commented Oct 1, 2019

This PR:

Fixes #798

Just add some new blank lines for the console output.

tests-checker[bot]
tests-checker bot suggested changes Oct 1, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Infection. We noticed you didn't add any tests. Could you please add them to make sure everything works as expected?

@maks-rafalko maks-rafalko self-requested a review October 2, 2019 04:14
maks-rafalko
maks-rafalko approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, looks good to me 👍

@maks-rafalko maks-rafalko added this to the 0.15.0 milestone Oct 2, 2019
@sanmai
Copy link
Member

sanmai commented Oct 3, 2019

Looking at the Travis' build log... We now have an extra new line:

Processing source code files: 3


Creating mutated files and processes: 22

#798 might not be as easy as it looks.

@kpn13
Copy link
Contributor Author

kpn13 commented Oct 3, 2019 •
edited

I think it's better now. Should I rebase my branch ?

@maks-rafalko maks-rafalko modified the milestones: 0.15.0, 0.14.2 Oct 3, 2019
@maks-rafalko
Copy link
Member

maks-rafalko commented Oct 3, 2019 •
edited

Since this is a bugfix, could you please target it to 0.14 branch so we can release it as 0.14.2?

@kpn13 kpn13 changed the base branch from master to 0.14 October 3, 2019 12:14
@maks-rafalko maks-rafalko merged commit e446812 into infection:0.14 Oct 5, 2019
@maks-rafalko
Copy link
Member

Thank you @kpn13

@maks-rafalko maks-rafalko mentioned this pull request Oct 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker requested changes

@maks-rafalko maks-rafalko maks-rafalko approved these changes

@BackEndTea BackEndTea BackEndTea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kpn13 @sanmai @maks-rafalko @BackEndTea