Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log phpunit output to console when in debug mode #683

Merged
merged 2 commits into from May 1, 2019
Merged

Log phpunit output to console when in debug mode #683

merged 2 commits into from May 1, 2019

Conversation

BackEndTea
Copy link
Member

@BackEndTea BackEndTea commented Apr 25, 2019 •
edited

This PR:

  • Logs PHPUnits output to the commandline when the --debug flag is used
  • Covered by tests

Fixes #520

@maks-rafalko maks-rafalko mentioned this pull request Apr 27, 2019
Closed
3 tasks
maks-rafalko
maks-rafalko approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BackEndTea

Do we need to mention it somewhere in the docs?

I'm starting thinking about creating a "How to debug.." article on our documentation site. This is out of the scope of this PR though

maks-rafalko
maks-rafalko requested changes Apr 27, 2019
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing https://travis-ci.org/infection/infection/jobs/524447139#L684

@maks-rafalko maks-rafalko added this to the 0.13.0 milestone Apr 27, 2019
@BackEndTea
Copy link
Member Author

Appveyor issue is due to codecov error. Travis is due to msi

@maks-rafalko
Copy link
Member

Thank you @BackEndTea !

@maks-rafalko maks-rafalko merged commit 5264654 into infection:master May 1, 2019
@BackEndTea
Copy link
Member Author

Thank you @borNfreee

@BackEndTea BackEndTea deleted the feature/log-phpunit-to-console-on-debug branch May 1, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maks-rafalko maks-rafalko maks-rafalko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

Log the InitialTestsRun command line when --debug is used
2 participants
@BackEndTea @maks-rafalko