New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New mutator for bcmath #678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the second awesome PR and adding support for extensions 👍
A couple of comments to discuss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this is it. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @majkel89 for your work and patience, really appreciate it. Great mutator!
This PR:
Fixes #658
Supported functions:
bcadd($a, $b, $mod)
->(string) ($a + $b)
bcdiv($a, $b, $mod)
->(string) ($a / $b)
bcmod($a, $b, $mod)
->(string) ($a % $b)
bcmul($a, $b, $mod)
->(string) ($a * $b)
bcpow($a, $b, $mod)
->(string) ($a ** $b)
bcsub($a, $b, $mod)
->(string) ($a - $b)
bcsqrt($a, $mod)
->(string) sqrt($a)
bcpowmod($a, $b, $c, $mod)
->(string) (pow($a, $b) % $c)
bccomp($a, $b, $mod)
->$a <=> $b
New profile @extensions created to hold this mutator. It is on by default.
Configuration