Use parent array for coverage #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you please rebase on master? |
3 tasks
BackEndTea
force-pushed
the
feature/better-array-coverage
branch
from
a7df6f3
to
9693953
Compare
|
Appveyor failure is due to a http request failing for schema validation. |
ghost
removed
the
|
Thank you @borNfreee |
|
@borNfreee Is there a new release with this bugfix planned soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
As shown here, array coverage is a bit wonky, and not all items are considered covered, except if function/methods are called as part of the array.
This PR should make sure that any array is properly covered.
It isn't properly tested, as the MutationsCollectorVisitor is a bit complex. I'll create a separate PR, to fix that up later.
Fixes #652