Error when parsing method that creates anonymous class

[remorhaz]

Question	Answer
Infection version	0.11.5 (infection.phar --version)
Test Framework version	PHPUnit 7.5.2
PHP version	7.1.27 (php -v)
Platform	Linux
Github Repo	-

Infection reports an error if the following code occurs in source folder:

namespace My\Namespace;

class Bug
{

    public function createAnonymousClass()
    {
        new class
        {
            public function foo()
            {
            }
        };
    }
}

The error is:

In CodeCoverageMethodIgnoreVisitor.php line 56:

  Method foo does not exist

Seems that code seeks method in host class instead of anonymous one, because if I add private function foo() {} to Bug class, the error dissapears.
I don't know either bug is in PHP-Parser or in Infection, but it affects your software anyway.

[BackEndTea]

I think we have some tests on dealing with anonymous classes, but maybe not for the CodeCoverageMethodIgnoreVisitor.

This could either be solved here:

infection/src/Visitor/ReflectionVisitor.php

Line 74 in 8a4d0fb

if ($node instanceof Node\Stmt\ClassLike && isset($node->fullyQualifiedClassName)) {

By keeping a stack of the fqn, in the same way we do with the functions. here:

infection/src/Visitor/ReflectionVisitor.php

Line 95 in 8a4d0fb

$this->scopeStack[] = $node;

Or we can solve it by wraping the following line in a try{}catch{}, and returing null in the catch.

infection/src/Visitor/CodeCoverageMethodIgnoreVisitor.php

Line 56 in 8a4d0fb

$method = $reflection->getMethod($node->name->toString());

I'm more of a fan of the first solution since it will prevent the same kind of error in the future, but it may require more refactoring in other places.