Fix: Set cacheResult attribute to false in phpunit.xml #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
commented
Dec 8, 2018
| @@ -107,6 +107,7 @@ public function build(string $version): string | |||
| $this->xmlConfigurationHelper->replaceWithAbsolutePaths($xPath); | |||
| $this->xmlConfigurationHelper->setStopOnFailure($xPath); | |||
| $this->xmlConfigurationHelper->deactivateColours($xPath); | |||
| $this->xmlConfigurationHelper->deactivateResultCaching($xPath); | |||
| $this->xmlConfigurationHelper->removeCacheResultFile($dom, $xPath); | |||
There was a problem hiding this comment.
The question is whether we still need to remove the cacheResultFile attribute, then.
What do you think?
There was a problem hiding this comment.
Seems like it's not needed anymore. I would remove this code
|
🤔 |
localheinz
force-pushed
the
fix/cache-result
branch
2 times, most recently
from
1bae9b6
to
6d85f5b
Compare
1 task
All new files must pass this check, but for the old ones, I think we can ignore it (it's unrelated to your PR). Of course, increasing the MSI is a good thing though. Probably we need target |
localheinz
force-pushed
the
fix/cache-result
branch
from
6d85f5b
to
18e5f08
Compare
maks-rafalko
approved these changes
Dec 9, 2018
|
Thank you, @borNfreee! |
|
Released 0.11.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
cacheResultattribute tofalseinphpunit.xmlto disable result caching entirelycacheResultFileattribute fromphpunit.xmlFollows #582.