Make PHPUnit 10.1 XML coverage report and test cases names with provider compatible with Infection and old format #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der compatible with Infection and old format In PHPUnit >=10 data providers with keys are stored as `Class\\test_method#some key` In PHPUnit <10 data providers with keys are stored as `Class\\test_method with data set "some key"`. We need to translate to the old format because this is what PHPUnit <10 and >=10 understand from CLI `--filter` option. In other words, PHPUnit 10 has a BC break in XML coverage reports that this PR workarounds.
sidz
approved these changes
May 13, 2023
|
thank you, @sidz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHPUnit >=10 data providers with keys are stored as
Class\\test_method#some keyIn PHPUnit <10 data providers with keys are stored as
Class\\test_method with data set "some key".We need to translate to the old format because this is what PHPUnit <10 and >=10 understand from CLI
--filteroption.In other words, PHPUnit 10 has a BC break in XML coverage reports that this PR workarounds.
Fixes #1825