Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use merge-base (three dot diff) instead of direct diff (#1653) (#1654) #1655

Merged
merged 4 commits into from Jan 27, 2022

Conversation

bdsl
Copy link
Contributor

@bdsl bdsl commented Jan 26, 2022

Cherry picked from commit ae4435e on master

  • Use merge-base (three dot diff) instead of direct diff for git-diff-base (git-diff-base should use merge-base instead of direct diff #1653)

  • Add command line dumping for debugging

  • Fetch full history to allow finding common ancestor, not just last commit

  • Remove var_dumps

  • Debug with git depth 1

  • Fall back to direct diff if merge base commit is not avialable

  • Restore deep git fetch

  • Kill UnwrapTrim mutant

…se (infection#1653) (infection#1654)

* Use merge-base (three dot diff) instead of direct diff for git-diff-base (infection#1653)

* Add command line dumping for debugging

* Fetch full history to allow finding common ancestor, not just last commit

* Remove var_dumps

* Debug with git depth 1

* Fall back to direct diff if merge base commit is not avialable

* Restore deep git fetch

* Kill UnwrapTrim mutant
@bdsl
Copy link
Contributor Author

bdsl commented Jan 26, 2022

I'm getting an error that the MSI is too low - but the MSI on the code I've added is 100%. Not sure what I should test to push the MSI up.

@maks-rafalko
Copy link
Member

It's fine, thank you @bdsl

@maks-rafalko maks-rafalko merged commit fefb689 into infection:0.26 Jan 27, 2022
@maks-rafalko
Copy link
Member

Released https://github.com/infection/infection/releases/tag/0.26.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants