Incompatible declaration of RealPathFilterIterator::toRegex()

[andreaskienast]

Question	Answer
Infection version	0.25.5 (infection.phar --version)
Test Framework version	PHPUnit/PhpSpec 9.5.11
symfony/finder version	4.4.36
PHP version	7.4.26 (php -v)
Platform	Ubuntu
Github Repo	-

Run infection with active filters is not possible anymore for us as we're hitting type incompatibilities (see the output in the summary).
The following command is sufficient to trigger the error:

php ./bin/infection --configuration=build/infection.json --filter=oh-noes

We're suspecting 6844063 to cause the issue.

Output with issue

    ____      ____          __  _
   /  _/___  / __/__  _____/ /_(_)___  ____
   / // __ \/ /_/ _ \/ ___/ __/ / __ \/ __ \
 _/ // / / / __/  __/ /__/ /_/ / /_/ / / / /
/___/_/ /_/_/  \___/\___/\__/_/\____/_/ /_/

Infection - PHP Mutation Testing Framework version 0.25.5

PHP Fatal error:  Declaration of Infection\FileSystem\Finder\Iterator\RealPathFilterIterator::toRegex(string $str): string must be compatible with Symfony\Component\Finder\Iterator\MultiplePcreFilterIterator::toRegex($str) in /var/www/html/vendor/infection/infection/src/FileSystem/Finder/Iterator/RealPathFilterIterator.php on line 80

Fatal error: Declaration of Infection\FileSystem\Finder\Iterator\RealPathFilterIterator::toRegex(string $str): string must be compatible with Symfony\Component\Finder\Iterator\MultiplePcreFilterIterator::toRegex($str) in /var/www/html/vendor/infection/infection/src/FileSystem/Finder/Iterator/RealPathFilterIterator.php on line 80

[maks-rafalko]

I believe we need to do the following change in Infection source code:

- protected function toRegex(string $str): string
+ protected function toRegex($str): string

because:

• Covariance allows a child's method to return a more specific type than the return type of its parent's method.
• Contravariance allows a parameter type to be less specific in a child method, than that of its parent.

then, Symfony 4-6 will be supported, see https://3v4l.org/gbbY7

Feel free to help

[andreaskienast]

Thank you for fixing this issue so fast!

[maks-rafalko]

Released as 0.25.6

Let us know if it doesn't work please :)

[andreaskienast]

I've pushed an update of infection to our CI and everything is fine again. Cheers! 🍻

[maks-rafalko]

Cool, thank you!