ignoreSourceCodeByRegex with no match should raise an Error
#1604
Comments
maks-rafalko
added a commit
that referenced
this issue
Dec 28, 2021
…n't matched Implements #1604 Will be useful to remove stale/non-matching `ignoreSourceCodeByRegex` settings inside `infection.json` and will help debugging them.
1 task
1 task
|
Unmatched regexes should not lead to a non-zero exit status by default as there could be version-dependent mutants which do not always appear and trigger a regex, among other things. Showing a notice should be fine, though. |
|
Another possibility would be to make the behaviour configurable, for example as PHPStan is doing it: https://phpstan.org/user-guide/ignoring-errors#reporting-unused-ignores |
|
Also when applying on a diff, this cannot work. But yeah maybe a confit entry or a flag could help. |
|
There are also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I've used quite few times
ignoreSourceCodeByRegex(both global and per-mutator) and it may happen that, after a refactor, an ignore regex is not necessary anymore. But Infection doesn't tell me that, so I might forget the regex in place, and that could be very bad if, in a later commit, a new line-of-code matches the forgotten regex by accident.Just like PHPStan fails when an ignore regex is set but has no match during the check, I'd like Infection too to have an exit code over zero for unmatched
ignoreSourceCodeByRegex.The text was updated successfully, but these errors were encountered: