Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace badge logger with more advanced stryker logger #1629

Merged
merged 2 commits into from Jan 8, 2022

Conversation

maks-rafalko
Copy link
Member

@maks-rafalko maks-rafalko commented Dec 27, 2021

This PR

Related to and depends on #1625

Now, Stryker logger allows to send badge information or the full mutation test elements report to display HTML report on Stryker Dashboard.

Example: https://dashboard.stryker-mutator.io/reports/github.com/infection/infection/master#mutant

Note, at the time of creating this PR, Stryker Dashboard has an old version of mutation-testing-elements lib which is too slow. Made a PR to update it: stryker-mutator/stryker-dashboard#211. The locally generated html report (see logger.html in infection.json already generates report with the latest lib)

This is a BC break.

Before:

infection.json

{
    "logs": {
        "badge": {
            "branch": "master"
        }
    }
}

After:

infection.json - for badge information only

{
    "logs": {
        "stryker": {
            "badge": "master"
        }
    }
}

or for badge and HTML report

{
    "logs": {
        "stryker": {
            "report": "master"
        }
    }
}

Additinoally, we can generate HTML report locally (#1625)

@maks-rafalko maks-rafalko added DX Developer Experience Feature labels Dec 27, 2021
@maks-rafalko maks-rafalko added this to the next milestone Dec 27, 2021
Base automatically changed from feature/html-report-new to master January 8, 2022 00:01
Related to #1625

Now, Stryker logger allows to send badge information or the full mutation test elements report to display HTML report on Stryker Dashboard.

Example: https://dashboard.stryker-mutator.io/reports/github.com/infection/infection/master#mutant

Note, at the time of creating this PR, Stryker Dashboard has an old version of mutation-testing-elements lib which is too slow. Made a PR to update it: stryker-mutator/stryker-dashboard#211. The locally generated `html` report (see `logger.html` in `infection.json` already generates report with the latest lib)

This is a BC break.

Before:

`infection.json`

```json
{
    "logs": {
        "badge": {
            "branch": "master"
        }
    }
}
```

After:

`infection.json` - for badge information only

```json
{
    "logs": {
        "stryker": {
            "badge": "master"
        }
    }
}
```

or for badge *and* HTML report

```json
{
    "logs": {
        "badge": {
            "report": "master"
        }
    }
}
```
@maks-rafalko maks-rafalko merged commit a749d72 into master Jan 8, 2022
@maks-rafalko maks-rafalko deleted the feature/stryker-setting branch January 8, 2022 00:28
@maks-rafalko maks-rafalko modified the milestones: next, 0.26.0 Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break DX Developer Experience Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant