Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit e2e-runner and test PHAR on PHP 8.0 with Xdebug #1610

Merged
merged 1 commit into from Dec 10, 2021
Merged

Use explicit e2e-runner and test PHAR on PHP 8.0 with Xdebug #1610

merged 1 commit into from Dec 10, 2021

Conversation

maks-rafalko
Copy link
Member 

- Tests / CI on ubuntu-latest with PHP 8.1, using pcov with 
+ Tests / CI on ubuntu-latest with PHP 8.1, using pcov with `bin/infection`
+ Tests / CI on ubuntu-latest with PHP 8.1, using pcov with `build/infection.phar`
  • Now all jobs will have correct displayed names
  • Conditions are now positive == 'build/infection.phar instead of negative != 'bin/infection. Because empty string inside e2e-runner was resulted to true with negative condition
  • New step: test PHAR on PHP 8.0 with Xdebug (in addition to pcov)

@maks-rafalko maks-rafalko enabled auto-merge (squash) December 10, 2021 14:52
@maks-rafalko maks-rafalko merged commit 9885adf into master Dec 10, 2021
@maks-rafalko maks-rafalko deleted the bugfix/correct-jobs branch December 10, 2021 16:10
@maks-rafalko
Copy link
Member Author

thank you, @sanmai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmai sanmai sanmai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maks-rafalko @sanmai