Display time and consumed memory even in case of insufficient MSI #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Time: 3s. Memory: 15Mb` - this is printed on `ApplicationExecutionWasFinished` event, but if MSI check fails, exception is thrown and `ApplicationExecutionWasFinished` is not dispatched, so time and memory is not printed. This change fixes the issue. Now, `ApplicationExecutionWasFinished` event is dispatched regardless of thrown exception
theofidry
approved these changes
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time: 3s. Memory: 15Mb- this is printed onApplicationExecutionWasFinishedevent, but if MSI check fails, exception is thrown andApplicationExecutionWasFinishedis not dispatched, so time and memory is not printed.This change fixes the issue. Now,
ApplicationExecutionWasFinishedevent is dispatched regardless of thrown exceptionBefore:
After: