Generate infection.json (without .dist postfix) by default
#1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son file and **any** IDE automatically understands it. Currently, generated `.dist` file is not recognized as JSON file by PHPStorm, which makes it work like usual text file, where JSON autocompletion won't work
sidz
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
shouldn't we rename our own infection.json.dist (https://github.com/infection/infection/blob/master/infection.json.dist) to just infection.json as part of this PR?
|
Makes sense, thanks. Updated |
maks-rafalko
force-pushed
the
feature/json-instead-of-dist
branch
from
cdc8fa6
to
3eff3fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate
infection.json(without.distpostfix) because this is a json file and any IDE automatically understands it.Currently, generated
.distfile is not recognized as JSON file by PHPStorm, which makes it work like usual text file, where JSON autocompletion won't workRelated to #1553