Remove CodeCoverageAnnotationIgnorer #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without annotation:
4 mutations were generated:
3 mutants were killed
0 mutants were not covered by tests
1 covered mutants were not detected
With annotation:
2 mutations were generated:
2 mutants were killed
0 mutants were not covered by tests
0 covered mutants were not detected
maks-rafalko
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
@infection-ignore-allworks on class level too as we say in the docs.Since we have a very explicit annotation
@infection-ignore-all(added in #1468) that, again, very explicit on the purpose, and works not only for methods, but for most kinds of statements, let's remove@codeCoverageIgnoreignorer, that not only implicit (you may only want to ignore a piece of code temporarily, and only ignore) but also messes up the metrics (hides otherwise-uncovered mutations).