Multiplication mutator should not mutate when return value is integer #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maks-rafalko
reviewed
May 3, 2021
composer.json
Outdated
| @@ -46,7 +46,7 @@ | |||
| "ext-dom": "*", | |||
| "ext-json": "*", | |||
| "ext-libxml": "*", | |||
| "composer/xdebug-handler": "^1.3.3", | |||
| "composer/xdebug-handler": "^2.0", | |||
There was a problem hiding this comment.
seems like this commit should not be in this PR (already in master)
| @@ -94,7 +96,19 @@ public function canMutate(Node $node): bool | |||
| return false; | |||
| } | |||
|
|
|||
| return true; | |||
| $functionScope = $node->getAttribute(ReflectionVisitor::FUNCTION_SCOPE_KEY); | |||
There was a problem hiding this comment.
I believe we should also check that the current node is a return expression as it's done e.g. here: https://github.com/infection/infection/blob/master/src/Mutator/ReturnValue/This.php#L84
Otherwise, the following code will not be mutated, but it should:
public function mul(int $a, int $b): int
{
$c = $a * $b;
return 1;
}btw, could you please add such case to tests so that we are sure it is mutated?
sidz
force-pushed
the
not-mutate-multiplication-mutate-returns-integer
branch
from
233ee09
to
c9bb822
Compare
|
Thank you @sidz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1514 request.