Upgrade xdebug-handler to v2 and handle that coverage option is set
#1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in case of Xdebug 3
sidz
changed the title
coverage option is set…coverage option is set
maks-rafalko
approved these changes
Apr 26, 2021
src/Console/XdebugHandler.php
Outdated
| @@ -52,7 +52,7 @@ public static function check(LoggerInterface $logger): void | |||
| { | |||
| // We force the color option unconditionally since it is able to detect the --no-ansi option | |||
| // to disable it if necessary | |||
There was a problem hiding this comment.
is this comment still relevant since no --ansi argument is passed anymore?
|
Thank you @sidz |
This was referenced Apr 26, 2021
maks-rafalko
pushed a commit
that referenced
this pull request
Apr 26, 2021
…#1510) * Upgrade xdebug-handler to v2 and handle that `coverage` option is set in case of Xdebug 3 * remove comment block as outdated
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade xdebug-handler to v2 and handle that
coverageoption is set in case of Xdebug 3Feature Request: #1509
Issue: #1473