Fix issue with order of keys in the config array #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case when profile setting is higher than mutator setting in the Infection configuration file
sanmai
commented
Nov 3, 2020
| @@ -15,6 +15,7 @@ parameters: | |||
| - '#^Cannot call method (willReturn|shouldBeCalledTimes)\(\) on iterable<Infection\\Mutation\\Mutation>\.$#' | |||
| - '#Offset .*\\.* does not exist on array<class-string<.*>.*#' | |||
| - '#Dynamic call to static method PHPUnit\\Framework\\Assert::(.*)#' | |||
| - '#Call to method PHPUnit\\Framework\\Assert::.* with array.* and array.* will always evaluate to false#' | |||
There was a problem hiding this comment.
For these:
./vendor/bin/phpstan analyse --configuration devTools/phpstan-tests.neon --no-interaction --no-progress
------ ----------------------------------------------------------
Line Mutator/MutatorResolverTest.php
------ ----------------------------------------------------------
348 Call to method PHPUnit\Framework\Assert::assertSame() with array('Infection\\Mutator\\Number\\DecrementInteger' => array('ignore' => array('Infected…')), 'Infection\\Mutator\\Number\\IncrementInteger' => array(),
'Infection\\Mutator\\Number\\OneZeroFloat' => array(), 'Infection\\Mutator\\Number\\OneZeroInteger' => array()) and array<class-string<Infection\Mutator\ConfigurableMutator>, array<string, mixed>> will always evaluate to false.
377 Call to method PHPUnit\Framework\Assert::assertSame() with array('Infection\\Mutator\\Number\\DecrementInteger' => array('ignore' => array('Infected…')), 'Infection\\Mutator\\Number\\IncrementInteger' => array(),
'Infection\\Mutator\\Number\\OneZeroFloat' => array(), 'Infection\\Mutator\\Number\\OneZeroInteger' => array()) and array<class-string<Infection\Mutator\ConfigurableMutator>, array<string, mixed>> will always evaluate to false.
------ ----------------------------------------------------------
I wish I knew why PHPStan thinks this stands true.
sidz
approved these changes
Nov 3, 2020
| ]); | ||
|
|
||
| $this->assertSame( | ||
| [ |
There was a problem hiding this comment.
I thought about more generic way to build expected result otherwise we will need to fix this test each time when we add new mutator to the @number profile (do not expect that it may happen often).
There was a problem hiding this comment.
Yeah, it should be possible to make this test a little less brittle, but it'll cost in visibility which I think isn't worth it right now.
maks-rafalko
approved these changes
Nov 3, 2020
|
Thank you @sidz and @maks-rafalko |
maks-rafalko
pushed a commit
that referenced
this pull request
Nov 3, 2020
* Add test that profile settings override particular mutator setting in case when profile setting is higher than mutator setting in the Infection configuration file * Fix #1408 * Fix issue where both mutator and profile have settings Co-authored-by: Oleg Zhulnev <plbsid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #1409:
mutatorsconfig array, leads to different results #1408