Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add phpstan/phpstan-strict-rules, add all errors to baseline files #1393

Merged
merged 3 commits into from Oct 31, 2020
Merged

Add phpstan/phpstan-strict-rules, add all errors to baseline files #1393

merged 3 commits into from Oct 31, 2020

Conversation

maks-rafalko
Copy link
Member

@maks-rafalko maks-rafalko commented Oct 30, 2020 •
edited

This PR:

  • adds phpstan-strict-rules plugin
  • adds all reported errors to the baseline file. There hundreds of them, the purpose of this PR is not to fix them, but prevent future ones

Base automatically changed from rector-php-7.4 to master October 30, 2020 20:47
@maks-rafalko
Add phpstan/phpstan-strict-rules, add all errors to baseline files
ff77f84
@maks-rafalko
Move config files back to devTools folder and correctly generate ba…
261d641 
…seline file

```
./vendor/bin/phpstan analyse --configuration devTools/phpstan-src.neon --no-interaction --no-progress --generate-baseline=devTools/phpstan-src-baseline.neon
```
@maks-rafalko maks-rafalko merged commit e6750b0 into master Oct 31, 2020
@maks-rafalko maks-rafalko deleted the feature/phpstan-strict-rules branch October 31, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmai sanmai Awaiting requested review from sanmai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@maks-rafalko