Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mutant $limit 0, -1 in preg_split #1345

Closed
vjik opened this issue Oct 18, 2020 · 2 comments
Closed

Don't mutant $limit 0, -1 in preg_split #1345

vjik opened this issue Oct 18, 2020 · 2 comments
Labels
PR merged
Milestone
0.19

Comments

@vjik
Copy link

vjik commented Oct 18, 2020

In function preg_split argument limit with values 0 and -1 behaves the same way. It would be cool if there was no mutation 0 to -1 and -1 to 0.
@maks-rafalko maks-rafalko added this to the 0.19 milestone Oct 18, 2020
@maks-rafalko
Copy link
Member

Hello, totally agree that this shouldn't be mutated.

Feel free to help us and fix it, shouldn't be hard. Mutator that does it is:

infection/src/Mutator/Number/DecrementInteger.php

Line 48 in 8109917

final class DecrementInteger extends AbstractNumberMutator

@sidz sidz mentioned this issue Oct 18, 2020
Merged
@sidz sidz added the Has PR label Oct 18, 2020
@vjik vjik mentioned this issue Oct 18, 2020
Closed
@maks-rafalko
Copy link
Member

Fixed in #1347

@maks-rafalko maks-rafalko modified the milestones: 0.19, 0.20.0 Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR merged
Projects
None yet
Milestone
0.19
Development

Successfully merging a pull request may close this issue.

Don't mutant $limit 0, -1 in preg_split vjik/infection
3 participants
@vjik @sidz @maks-rafalko