Dedicated static function to parse out mutator name #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmai
commented
Sep 15, 2020
| $parts = explode('\\', $className); | ||
|
|
||
| return (string) end($parts); | ||
| } |
There was a problem hiding this comment.
Closest place where Mutator::getName() is used.
3 tasks
maks-rafalko
approved these changes
Sep 15, 2020
|
Looks a bit weird to me that it's the factory responsible for giving the mutator name (by default) – even more so than an object depends on its external factory IMO |
|
It is. Should be easy to refactor. What do you have in mind? |
|
What was wrong with how it was before? I saw there was a bunch of PRs so maybe I missed the overall picture |
|
It was only an instance method before (still is), but sometimes you want to get a name for a mutator having only a class name for it. |
|
Do you have a place where this is the case? I think it would help to understand what's going on because indeed it's a bit tricky |
|
Sure, right about here. |
|
Replied there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: