Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install test framework adapters as dev dependencies #1262

Merged
merged 1 commit into from Apr 26, 2020
Merged

Install test framework adapters as dev dependencies #1262

merged 1 commit into from Apr 26, 2020

Conversation

maks-rafalko
Copy link
Member

@maks-rafalko maks-rafalko commented Apr 25, 2020 •
edited

Since Infection is for development purposes, adapter must be installed as dev dependencies as well.

php-cs-fixer's failure is unrelated and fixed in master

tests-checker[bot]
tests-checker bot suggested changes Apr 25, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Infection. We noticed you didn't add any tests. Could you please add them to make sure everything works as expected?

@maks-rafalko maks-rafalko merged commit 52d597a into 0.16 Apr 26, 2020
@maks-rafalko maks-rafalko deleted the hotfix/install-adapter-as-dev branch April 26, 2020 11:15
@maks-rafalko
Copy link
Member Author

Thank you @theofidry & @BackEndTea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker requested changes

@theofidry theofidry theofidry approved these changes

@BackEndTea BackEndTea BackEndTea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maks-rafalko @theofidry @BackEndTea