Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accepted ADR entries #1192

Merged
merged 4 commits into from Mar 20, 2020
Merged

Add accepted ADR entries #1192

merged 4 commits into from Mar 20, 2020

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Mar 20, 2020

Add ADR entries for some conventions or practices that have been discussed in the course of the last few months.

This PR is not an attempt or invitation to challenge any of those decisions: those are decisions already made. If you wish to challenge or change one, this should be discussed and done in a separate issue/PR.

adr/0002-@covers-annotations.md Outdated Show resolved Hide resolved
adr/0002-@covers-annotations.md Outdated Show resolved Hide resolved
adr/0002-@covers-annotations.md Outdated Show resolved Hide resolved
adr/0003-PHPUnit-this-over-self.md Outdated Show resolved Hide resolved
@theofidry theofidry merged commit d25c734 into infection:master Mar 20, 2020
@theofidry theofidry deleted the adr/covers branch March 20, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants