Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/support eslint8 #43

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Chore/support eslint8 #43

merged 3 commits into from
Oct 15, 2021

Conversation

johnmartel
Copy link
Contributor

@johnmartel johnmartel commented Oct 14, 2021

Closes #42

The `jest` dependency was updated because tests could not be run after
upgrading the eslint dependencies. I had the following error:

```
TypeError: The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received 'http://localhost/eslintrc.cjs'

      at Function.createRequire (node_modules/jest-runtime/build/index.js:1418:23)
      at Object.<anonymous> (node_modules/@eslint/eslintrc/lib/config-array-factory.js:57:17)
      at Object.<anonymous> (node_modules/eslint/lib/cli-engine/cli-engine.js:33:5)
```
- `meta.docs.category` was removed from
  `@typescript-eslint/experimental-utils`.
- adjusted incorrect type for rule metadata.schema

See: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.0.0
@infctr
Copy link
Owner

infctr commented Oct 15, 2021

@etienems2 Appreciate your contribution!

error @typescript-eslint/experimental-utils@5.0.0: The engine "node" is incompatible with this module. Expected version "^12.22.0 || ^14.17.0 || >=16.0.0". Got "10.24.1"

Let's drop support for node v10 and add v16 to testing matrix

@johnmartel
Copy link
Contributor Author

Let's drop support for node v10 and add v16 to testing matrix

@infctr Good point, I made the change :)

@infctr infctr merged commit 5016820 into infctr:master Oct 15, 2021
@johnmartel johnmartel deleted the chore/support-eslint8 branch October 15, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x
3 participants