Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug_remote_on_single_rank #498

Merged
merged 16 commits into from Dec 29, 2021

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented Dec 28, 2021

Continuation of #496.

@matthiasdiener matthiasdiener marked this pull request as ready for review December 29, 2021 11:36
@matthiasdiener
Copy link
Contributor Author

Ready for review @inducer. I added better docs.

@inducer
Copy link
Owner

inducer commented Dec 29, 2021

I tried to fix this, but Github IDE didn't let me commit. Here are the changes I made:

image

@matthiasdiener
Copy link
Contributor Author

I tried to fix this, but Github IDE didn't let me commit. Here are the changes I made:

image

Thanks, I've integrated your changes and made the callable take arguments, like the non-MPI implementation. This is ready for another review.

@inducer inducer enabled auto-merge (squash) December 29, 2021 18:32
@inducer
Copy link
Owner

inducer commented Dec 29, 2021

Looks great, thanks!

@inducer inducer merged commit 8caead2 into inducer:main Dec 29, 2021
@matthiasdiener matthiasdiener deleted the debug_remote_on_single_rank branch December 29, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants