-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with PHPUnit 9 #32
Comments
Hi, In version 9 of PHPUnit, the printer needs to inherit from the class class PrettyPrinter extends ResultPrinter implements TestListener {} And can be replaced by : class PrettyPrinter extends DefaultResultPrinter {} I don't know if the implementation change with version 9 and the documentation can be found here. |
The latest release should work with PHPUnit 9. |
Hello, I see in this repo that the fix was implemented (https://github.com/indentno/phpunit-pretty-print/blob/develop/src/PrettyPrinter.php) Can a new PHPUnit 9 compatible release be made please ? |
Are you using the correct PrettyPrinter class? (The readme specifies that you should use the \Sempro\PHPUnitPrettyPrinter\PrettyPrinterForPhpUnit9 class for PHPUnit 9) |
All my apologies, indeed it was well written in the README.md included in the package... but I missed it :/ In the phpunit XML config I changed the You can close this ticket again, sorry for the waste of time and many thanks for your quick answer ! (and by the way for this fantastic piece of code !!) For future people like me, the information is now in this ticket O:) /**
* For PHPUnit9 you must use instead {@see PrettyPrinterForPhpUnit9}
*
* @deprecated 1.4.0
*
* @link https://github.com/indentno/phpunit-pretty-print/issues/32 Fix for PHPUnit9 compatibility
*/ |
No worries. Thank you for the kind words 🙂 Feel free to send in a Pull Request with the changes you suggested! |
As #28 is not resolved this now doesn't work with PHPUnit 9.
We should fix it or limit the version constraint.
The text was updated successfully, but these errors were encountered: