Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import/no-empty-named-blocks false positive in many cases #2667

Closed
zloirock opened this issue Jan 12, 2023 · 4 comments
Closed

import/no-empty-named-blocks false positive in many cases #2667

zloirock opened this issue Jan 12, 2023 · 4 comments

Comments

@zloirock
Copy link
Contributor

zloirock commented Jan 12, 2023

image

Triggers from the last 3 files:

import { DESCRIPTORS, NODE } from '../helpers/constants';
// ...
import { timeLimitedPromise } from '../helpers/helpers';
// ...
import { DESCRIPTORS } from '../helpers/constants';

In every file all errors on 1:1 position. No one of them has empty named blocks.

@ljharb
Copy link
Member

ljharb commented Jan 12, 2023

hmm, i can't seem to reproduce these. What eslint parser are you using? (i tried the default one)

@ljharb
Copy link
Member

ljharb commented Jan 12, 2023

Either way, the entire implementation of this rule needs to be rewritten to solve #2666, so hopefully the next release will address this issue.

@ljharb
Copy link
Member

ljharb commented Jan 12, 2023

v2.27.3 is released; give that a shot.

@zloirock
Copy link
Contributor Author

It seems it's fixed in 2.27.4.

JiriLojda added a commit to kontent-ai/eslint-config that referenced this issue May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants