Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Cannot find module 'typescript' #1809

Closed
fyangstudio opened this issue Jun 8, 2020 · 4 comments
Closed

CI Cannot find module 'typescript' #1809

fyangstudio opened this issue Jun 8, 2020 · 4 comments

Comments

@fyangstudio
Copy link

fyangstudio commented Jun 8, 2020

Error:
Cannot find module 'typescript'
with eslint-plugin-import@.2.21.1 in CI:

https://travis-ci.com/github/raxjs/rax-vscode-extensions/builds/170236677
image

eslint-plugin-import@2.20.0 is ok.

@ljharb
Copy link
Member

ljharb commented Jun 8, 2020

That doesn’t make any sense to me; 2.21.0 unconditionally required typescript (#1805), but 2.21.1 only does so when encountering typescript nodes.

Can you share the code it’s erroring on?

@fyangstudio
Copy link
Author

fyangstudio commented Jun 9, 2020

It's happened in travis CI env.
It's works OK and no error occurred in my local development env as well.

I use the same Node and NPM version, with same command travis CI env failed, local development env is OK.

Code:
https://unpkg.com/browse/eslint-config-rax@0.0.3/rules/base.js

@ljharb
Copy link
Member

ljharb commented Jun 9, 2020

This line is unnecessary (the local one is used), but otherwise nothing looks out of place, and I can't reproduce it locally.

(I'm not sure why npm run setup is so abysmally slow, it seems to take longer than most lerna monorepos I've used)

Have you tried deleting all your travis-ci caches, and then rerunning the failed builds?

@fyangstudio
Copy link
Author

fyangstudio commented Jun 9, 2020

It's seems good, when i remove travis-ci caches.
Maybe this issue is caused by travis-ci caches. thx

@ljharb ljharb closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants