Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.20.2 introduces a breaking change/bug. #1760

Closed
dwjohnston opened this issue May 12, 2020 · 2 comments
Closed

2.20.2 introduces a breaking change/bug. #1760

dwjohnston opened this issue May 12, 2020 · 2 comments

Comments

@dwjohnston
Copy link

I have a repro for this here:

https://github.com/dwjohnston/eslint-import-order-repro

On a file like this:

import foo from '.'
import bar from '..'

console.log(foo, bar)

On version 2.20.1 this is valid, but on 2.20.2 this will give

`..` import should occur before import of `.`eslintimport/order
@golopot
Copy link
Contributor

golopot commented May 13, 2020

This is an intentional change made in #1658 . It is a bug fix that introduces more warnings. According to https://github.com/eslint/eslint/blob/master/README.md#semantic-versioning-policy it belongs to a minor release.

@ljharb
Copy link
Member

ljharb commented May 13, 2020

Fair that it perhaps should have been a minor.

However, I'm releasing a v2.21.0 shortly, so i'd rather roll forward than backwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants