From cd48ef60697b40e2cd4528d34ed9cd3ae6aaaaf2 Mon Sep 17 00:00:00 2001 From: Edward Grech Date: Wed, 24 Feb 2021 09:37:06 +0100 Subject: [PATCH 1/2] [Docs] `no-extraneous-dependencies`: correct peerDependencies option default to `true` --- CHANGELOG.md | 5 ++++- docs/rules/no-extraneous-dependencies.md | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bb38ab5ab7..3b9edced61 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel ### Changed - [Generic Import Callback] Make callback for all imports once in rules ([#1237], thanks [@ljqx]) - [Docs] [`no-named-as-default`]: add semicolon ([#1897], thanks [@bicstone]) +- [Docs] `no-extraneous-dependencies`: correct peerDependencies option default to `true` ([#1993], thanks [@dwardu]) ## [2.22.1] - 2020-09-27 ### Fixed @@ -759,6 +760,7 @@ for info on changes for earlier releases. [`memo-parser`]: ./memo-parser/README.md +[#1993]: https://github.com/benmosher/eslint-plugin-import/pull/1993 [#1983]: https://github.com/benmosher/eslint-plugin-import/pull/1983 [#1974]: https://github.com/benmosher/eslint-plugin-import/pull/1974 [#1958]: https://github.com/benmosher/eslint-plugin-import/pull/1958 @@ -1340,4 +1342,5 @@ for info on changes for earlier releases. [@panrafal]: https://github.com/panrafal [@ttmarek]: https://github.com/ttmarek [@christianvuerings]: https://github.com/christianvuerings -[@devongovett]: https://github.com/devongovett \ No newline at end of file +[@devongovett]: https://github.com/devongovett +[@dwardu]: https://github.com/dwardu diff --git a/docs/rules/no-extraneous-dependencies.md b/docs/rules/no-extraneous-dependencies.md index 295590ccd0..e9743a7619 100644 --- a/docs/rules/no-extraneous-dependencies.md +++ b/docs/rules/no-extraneous-dependencies.md @@ -13,7 +13,7 @@ This rule supports the following options: `optionalDependencies`: If set to `false`, then the rule will show an error when `optionalDependencies` are imported. Defaults to `true`. -`peerDependencies`: If set to `false`, then the rule will show an error when `peerDependencies` are imported. Defaults to `false`. +`peerDependencies`: If set to `false`, then the rule will show an error when `peerDependencies` are imported. Defaults to `true`. `bundledDependencies`: If set to `false`, then the rule will show an error when `bundledDependencies` are imported. Defaults to `true`. From d31d615e63e2e76d56d6c69b6eedfc94bc3f35a3 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Tue, 11 May 2021 23:12:50 -0700 Subject: [PATCH 2/2] [Tests] remove failing node 10 WSL test --- appveyor.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/appveyor.yml b/appveyor.yml index b79315b7be..de79234eb4 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -16,6 +16,8 @@ image: Visual Studio 2019 matrix: fast_finish: false exclude: + - configuration: WSL + nodejs_version: "10" - configuration: WSL nodejs_version: "8"