Generalize fromJS() and Seq() to support Sets #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When calling `Seq(value)` on an iterable value, use the convention of the default iterator method being equal to one of the prototype methods `value.entries()` and `value.keys()` as a clear indication of Keyed or Set style collections. - Introduces `isEntriesIterable()` and `isKeysIterable()` to capture these patterns. - Uses them within `Seq()` to produce an entries sequence or set sequence. - Use the general `Seq()` in the implementation of `fromJS()`, rather than repeating the logic of determining which Seq conversion to apply. - Replaces this logic with constraints on which values can be converted - Introduces allowing iterable objects - Introduces allowing array-likes - Add `toSet()` as a possible return from the default converter of `fromJS()` in the case the generated Seq is a SetSeq.
jdeniau
approved these changes
Jul 23, 2021
|
Hi, when do you expect to release this change? Thanks |
|
Hi @amr-labib. There will probably be a release in september. |
|
@amr-labib the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seq(value)on an iterable value, use the convention of the default iterator method being equal to one of the prototype methodsvalue.entries()andvalue.keys()as a clear indication of Keyed or Set style collections.isEntriesIterable()andisKeysIterable()to capture these patterns.Seq()to produce an entries sequence or set sequence.Seq()in the implementation offromJS(), rather than repeating the logic of determining which Seq conversion to apply.toSet()as a possible return from the default converter offromJS()in the case the generated Seq is a SetSeq.Fixes #1723