Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You added es bundle, but forgot about sideEffects:false #1661

Merged
merged 2 commits into from Jul 16, 2021

Conversation

a-x-
Copy link
Contributor

@a-x- a-x- commented Dec 10, 2018

No description provided.

@a-x- a-x- mentioned this pull request Dec 10, 2018
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@a-x- a-x- changed the title You added es bundle, but forget about sideEffects:false You added es bundle, but forgot about sideEffects:false Dec 10, 2018
@a-x-
Copy link
Contributor Author

a-x- commented Dec 10, 2018

What wrong with your ci? :)

@IllusionMH
Copy link

IllusionMH commented Dec 11, 2018

Compromised flatmap-stream and event-stream were unpublished from npm. More info: https://blog.npmjs.org/post/180565383195/details-about-the-event-stream-incident

Dependencies should be updated in yarn.lock

@ablakey
Copy link
Contributor

ablakey commented Dec 30, 2018

@a-x- have you tested if this change causes tree shaking to work? Does it work well with the current structure of Immutable? There's so much unused code I drag along in projects. I would love to see this capability be supported.

Any help I can offer in testing, updating documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants