Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to return on produce doc page #927

Merged
merged 1 commit into from Apr 23, 2022
Merged

Conversation

pzich
Copy link
Contributor

@pzich pzich commented Apr 15, 2022

The current format was linking to https://immerjs.github.io/immer/produce/return , which does not exist.

Disclaimer: I'm not actually sure how to build/host/test these docs myself, but I based this change off of the changes in bc35916

The current format was linking to https://immerjs.github.io/immer/produce/return , which does not exist
@netlify
Copy link

netlify bot commented Apr 15, 2022

Deploy Preview for quizzical-lovelace-dcbd6a ready!

Name Link
🔨 Latest commit 0e10a6b
🔍 Latest deploy log https://app.netlify.com/sites/quizzical-lovelace-dcbd6a/deploys/625a02d937e8a50008446818
😎 Deploy Preview https://deploy-preview-927--quizzical-lovelace-dcbd6a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pzich
Copy link
Contributor Author

pzich commented Apr 15, 2022

I just tested with the 😎 Deploy Preview linked above and it seems to work, but the path structure is different there so I'm not sure if it'll behave the same in production.

@mweststrate mweststrate merged commit 0a47a40 into immerjs:master Apr 23, 2022
@mweststrate
Copy link
Collaborator

LGTM, thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2174874584

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.553%

Totals Coverage Status
Change from base Build 2090904365: 0.0%
Covered Lines: 786
Relevant Lines: 794

💛 - Coveralls

@github-actions
Copy link
Contributor

🎉 This PR is included in version 9.0.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants