Append to array when key is "-" #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for quizzical-lovelace-dcbd6a canceled. 🔨 Explore the source changes: fe80e02 🔍 Inspect the deploy log: https://app.netlify.com/sites/quizzical-lovelace-dcbd6a/deploys/6195aa639e7cde0007f4a814 |
lourd
changed the title
|
Please me know if there's I can do to help push this along! Tests are passing for me locally on Node.js v12 and v14; looks the failures on v16 are unrelated. |
|
🎉 This PR is included in version 9.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #871
It's actually amazing '-' was doing anything at all! Definitely a JS quirk that the first argument to
spliceis coerced to a number, effectively becoming 0 if the parameter can't be parsed.I also dropped an unnecessary
anycast, and added a check for avoiding an unnecessary copy of the patch array.