Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputInt no longer hides +/- buttons despite having a .step(0) since v0.9.0 #758

Open
jestarray opened this issue Jan 1, 2024 · 1 comment

Comments

@jestarray
Copy link

jestarray commented Jan 1, 2024

ocornut/imgui#2653

Left is code, right is output:
imgui v0.8.0 (Arch Linux Glow Example)
image

imgui v0.9.0 to v0.11.0
image

.step(0) should remove the -/+ buttons like in v0.8.0 unless behavior changed in imgui itself. This seems to be unlikely as I could not find anything in their changelogs.

@jestarray
Copy link
Author

jestarray commented Jan 1, 2024

Found the bug:
v0.8.2:

InputInt::new(self, label, value)

https://github.com/imgui-rs/imgui-rs/blob/0.9-stable/imgui/src/lib.rs#L536

https://github.com/imgui-rs/imgui-rs/blob/main/imgui/src/lib.rs#L507

Someone made it so input_int always called it with .step(1) sometime during v0.8.2 -> v0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant