Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup cargo-semver-checks or similar in CI #694

Open
dbr opened this issue Jan 9, 2023 · 1 comment · May be fixed by #708
Open

Setup cargo-semver-checks or similar in CI #694

dbr opened this issue Jan 9, 2023 · 1 comment · May be fixed by #708
Milestone
v0.12

Comments

@dbr
Copy link
Contributor

dbr commented Jan 9, 2023

Something like this could be used to flag PR's have breaking changes in them

https://github.com/obi1kenobi/cargo-semver-checks

Would mean the CI would never be green on intentionally breaking changes, but practically that is fine
@dbr dbr added this to the v0.10 milestone Jan 9, 2023
This was referenced Jan 9, 2023
Closed
Merged
@dbr dbr modified the milestones: v0.10, v0.11 Jan 16, 2023
@dbr
Copy link
Contributor Author

dbr commented Jan 16, 2023

Moved to v0.11, not something that needs to hold-up v0.10 release

@Rob2309 Rob2309 linked a pull request Jan 21, 2023 that will close this issue
Draft
@dbr dbr modified the milestones: v0.11, v0.12 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12
Development

Successfully merging a pull request may close this issue.

Added experimental semver-check pipeline Rob2309/imgui-rs
1 participant
@dbr