New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support & upgrade to winit 0.25 #485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I do wonder if it's worth keeping support for winit-24. I suspect the valuable ones are 19, and latest (and everything in between doesn't matter so much). Oh well, this is fine for now.
(Ah, rather, it's fine pending green CI, ofc) |
Believe need to at least support the previous version (0.24) in this case to not force complex dependent upgrades. Even some examples in this repo used |
Hmm ok that can't really be solved as the CI builds the entire workspace which forces cargo feature resolver to unify all the features and build the Could change so just add support for 0.25 but keep the default here on 0.24 until glutin and the examples also can use 0.25, believe that is the only workable approach? |
SGTM |
Please file an issue for updating default to winit-25 once glutin supports it. Or I can remember to do so later today. |
Hm? I would have been fine merging 92bed93. |
This reverts commit d82c9a0.
Thanks. Sorry about the hassles here. I'll merge this in a bit and take care of filing the followup. |
Since this doesn't change the default feature I think I can cut this as a patch release (0.7.1) of imgui-winit-support too, which means I can probably get to it later today. |
Actually, I just did it now https://crates.io/crates/imgui-winit-support/0.7.1 |
Adds a new
winit-25
feature that works just like the previouswinit-24
.Leaves default for now on
winit-24
though asglutin
is still using it and can't mix and use multiple winit versions within this repo