Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGs are broken in aggressive mode #966

Open
Twixes opened this issue Jul 16, 2021 · 3 comments
Open

SVGs are broken in aggressive mode #966

Twixes opened this issue Jul 16, 2021 · 3 comments

Comments

@Twixes
Copy link

Twixes commented Jul 16, 2021

We used Imgbot on https://github.com/PostHog/posthog.com and recently enabled aggressive optimization to increase compression rates. Imgbot put out a PR with that aggressive optimization of images and it went well for raster images, but simply broke all our SVGs (PR PostHog/posthog.com#1568)

Default Aggressive
Good Bad

All the places where weirdly overflowing alt text is shown are SVG images in <img src="data:image/svg+xml;base64,{base64-encoded-svg-file}"> form.

@GrigoreMihai
Copy link
Contributor

Can you provide some images for which this is happening for us to look into the issue, or is it happening for all the svgs from that pr ( PostHog/posthog.com#1568 )?

@Twixes
Copy link
Author

Twixes commented Oct 27, 2021

Certainly many, posthog-logo-svg.svg (at the top of the files list) seems to be one example there, but not sure if all.

@VixieTSQ
Copy link

VixieTSQ commented Nov 8, 2021

if it at all helps the same thing happened to me. Here's my files
Original
Broken
for temporary fix you can just add:
"ignoredfiles": [ "*.svg" ]
to your .imgbotconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants