Fix Windows compatibility #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2020 15:36
…min cross platform imagemin relies on globby package which (at least as of time of this commit) expects paths to use forward slash (Unix) and not backward slash (Windows). To fix this issue, I've added additional step, converting filePaths to unix format. Unix format (forward slash) delimiter is supported in Windows for the most of cases. @see https://superuser.com/questions/176388/why-does-windows-use-backslashes-for-paths-and-unix-forward-slashes/176395\#176395
Closed
|
Is it solved |
|
I set glob = false, all right, But I have to iterate all files |
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds explicit conversion for input file paths to Unix format which uses forward slash.
imageminrelies onglobbypackage to calculate all file paths, when glob option is enabled. That package expects paths to use forward slashes as a path delimiter. When Windows path delimiter was encountered in the file name, the file was ignored, which resulted inimageminnot processing those files.I also added a test for Windows delimiter, to make sure
imageminworks with them correctly further down the road, but the test seems to me not super accurate because the tested path (generated bytempy) on Unix will contain both Unix and Windows path delimiters.If you have any idea how to test the issue more specifically, feel free to update!
Fixes #352