Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching globby to node-glob #314

Closed
maxnordlund opened this issue Apr 11, 2019 · 2 comments
Closed

Consider switching globby to node-glob #314

maxnordlund opened this issue Apr 11, 2019 · 2 comments

Comments

@maxnordlund
Copy link

Currently imagemin's install size is 2.70MB. After #313 this will go up ~1MB, thanks to globby pulling in fast-glob. On the flip side node-glob is very lightweight, so switching to that would save a fair few bytes every time this is downloaded from npm. At the time of writing this this is an impressive 629 886 times a week, that turns into ~1.9 terabyte a week saved. (Assuming 3MB saved, from the numbers below)

Size Link
3.27MB https://packagephobia.now.sh/result?p=globby
197kB https://packagephobia.now.sh/result?p=node-glob
@maxnordlund maxnordlund changed the title Consider switch globby to node-glob Consider switching globby to node-glob Apr 11, 2019
@sindresorhus
Copy link
Contributor

This has been fixed in the latest globby release: https://packagephobia.now.sh/result?p=globby

@maxnordlund
Copy link
Author

It's still a bit larger then node-glob but what an improvement, thanks man :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants