Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release does not contain commits #420

Closed
addisonElliott opened this issue Jan 8, 2019 · 1 comment
Closed

Latest release does not contain commits #420

addisonElliott opened this issue Jan 8, 2019 · 1 comment

Comments

@addisonElliott
Copy link
Contributor

Correct me if I'm wrong, but I authored a PR back in October of last year (#388) and a release has been published since then but does not contain my commit.

Maybe I'm going crazy, but it all seems very confusing. Let me walk you through what I mean...

First, if you look at the master branch, it shows my commit fine. Line 574 of the pillow.py plugin, you can see the "rawmode_saved" code I added to fix a special case. https://github.com/imageio/imageio/blob/master/imageio/plugins/pillow.py#L574

My PR was merged October 1, 2018. Version 2.4.1 was released on November 15th, 2018. Thus, my changes should be in v2.4.1.

Downloading the source directly from PyPi for v2.4.1, I look at the same file and my changes are not there.
Screenshot

Solution

Probably just release another version? Luckily I don't need these changes now but just wanted to bring to your attention.

@almarklein
Copy link
Member

You nearly had me going crazy too there :)

The 2.4.1 release was actually from 6 September. See e.g. pypi. This is also the date that this release was tagged. But apparently at some point in November I turned the tag to a "release" on Github, and Girhub will display the day that this was done (with no option to change it). I can see how this caused confusion! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants