Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageBuffer should also derive Hash, PartialEq and Eq #697

Closed
yoanlcq opened this issue Nov 26, 2017 · 1 comment
Closed

ImageBuffer should also derive Hash, PartialEq and Eq #697

yoanlcq opened this issue Nov 26, 2017 · 1 comment
Projects
Version 0.23

Comments

@yoanlcq
Copy link

yoanlcq commented Nov 26, 2017

Greetings,

Title says it all - I think this would be convenient for APIs that expose structs which happen to contain an ImageBuffer (as is the case for me).
Since it is a slight, non-breaking change, I didn't bother to do a PR - but it might also be an opportunity to dicuss this for other structs such as Frame.
@HeroicKatora HeroicKatora added this to Planned in Version 0.23 Feb 9, 2020
@soruh soruh mentioned this issue May 31, 2020
Merged
@HeroicKatora
Copy link
Member

This was fixed in #1248.

@HeroicKatora HeroicKatora moved this from New Features to Done in Version 0.23 Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Version 0.23
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HeroicKatora @yoanlcq