Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General support for 16bit color components #665

Closed
fungos opened this issue Jul 6, 2017 · 5 comments
Closed

General support for 16bit color components #665

fungos opened this issue Jul 6, 2017 · 5 comments

Comments

@fungos
Copy link

fungos commented Jul 6, 2017 •
edited

One major feature missing from this crate is the general support for 16 bits color components.
Before going forward with new Encoder/Decoder I believe this should be solved. I would try to tackle this, but seems a bit more of design issue, so maybe someone more experienced with Rust would be needed.

Relates to #426, #559 and #560.
@rennis250
Copy link

What is this status on this? What is required to finish this?

@polarathene
Copy link

+1 I'd like to process 16-bit PNGs(specifically greyscale).

@BartMassey
Copy link

Yes. I would like to generate 16bit grayscale images.

@HeroicKatora HeroicKatora mentioned this issue May 10, 2019
Closed
aschampion added a commit to aschampion/image that referenced this issue Nov 27, 2019
@aschampion
Support 16 bit per channel image buffers
88f929d 
Add 16 bit buffers for all 16 bit types in ColorType. Include these as
supported types in DynamicImage. These 16 bit images are currently only
supported with u16 representation; changing this would require
specialization and macroing of color conversions.

Load 16 bit PNGs at full bit depth rather than squashing to 8 bit.

Note that tests will not pass until upgrading to a release of image-png
including image-rs/image-png#174.

Closes image-rs#560.
Closes image-rs#665.
Closes image-rs#940.
aschampion added a commit to aschampion/image that referenced this issue Dec 4, 2019
@aschampion
Support 16 bit per channel image buffers
1f1b1c8 
Add 16 bit buffers for all 16 bit types in ColorType. Include these as
supported types in DynamicImage. These 16 bit images are currently only
supported with u16 representation; changing this would require
specialization and macroing of color conversions.

Load 16 bit PNGs at full bit depth rather than squashing to 8 bit.

Note that tests will not pass until upgrading to a release of image-png
including image-rs/image-png#174.

Closes image-rs#560.
Closes image-rs#665.
Closes image-rs#940.
@SolarLiner
Copy link

Any progress on this? I also would like to generate 16-bit PNG images.

@polarathene
Copy link

There appears to be in this issues history/timeline directly above your comment, is a commit from what is presumably a fork(and perhaps a PR) addressing it?:

Support 16 bit per channel image buffers
Add 16 bit buffers for all 16 bit types in ColorType. Include these as supported types in DynamicImage. These 16 bit images are currently only supported with u16 representation; changing this would require specialization and macroing of color conversions.

Load 16 bit PNGs at full bit depth rather than squashing to 8 bit.

Found the relevant PR here. So once that's passed review cycle and been merged, just have to wait until the next release with it is made :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@BartMassey @fungos @rennis250 @SolarLiner @polarathene