You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PngDecoder should also be changed. But sadly we can't support set_limits there without a breaking change.
The issue is a subtle problem with the type signature of PngDecoder::is_apng that doesn't let us return limit or parsing errors. Instead we have to do metadata parsing ahead of time in new/with_limits so that we can report those errors. But once we've parsed the metadata the crate doesn't let us set the allocation limit (and that's the correct approach because we want to use the limit to avoid allocating an unbounded amount of space for storing metadata!)
The text was updated successfully, but these errors were encountered:
This happens in
image
v0.24.7.Expected
PngDecoder
should support setting memory limits via the genericset_limits
method, not only via its ownwith_limits
method.Actual behaviour
Only the
with_limits
constructor sets limits correctly; setting limits viaset_limits
is not implemented.Quoting @fintelia :
The text was updated successfully, but these errors were encountered: