Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rayon should not be available as default feature #2028

Open
qarmin opened this issue Oct 14, 2023 · 1 comment
Open

Rayon should not be available as default feature #2028

qarmin opened this issue Oct 14, 2023 · 1 comment

Comments

@qarmin
Copy link

qarmin commented Oct 14, 2023

Currently I use image-rs library in 3 copies in my app.

One dependency is from my app, but two are from other libraries.

I want to disable rayon, because I use it for different calculations and I, but I cannot do this, because it is not currently possible to disable features in libraries that not allows to do this - e.g. imagepipe uses all default features without possibility to remove unnecessary features.

So to "fix" this, this feature should be disabled by default

Looks that ravif also uses rayon

@fintelia
Copy link
Contributor

Before we'd be able to consider whether rayon should be one of the default features, we first need to make sure it can be toggled by features at all. Right now, a couple of our dependencies use rayon without placing it behind a feature. If you're interested in changing this, the first step would be going through each place we include rayon from and making making a PR to have it be optional instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants