Check dimensions of dynamic image before resizing it

[VolkerFelix]

Should fix the issue: #1738

Not super happy with it since I'm cloning self but I didn't want to change the return type to &DynamicImage e.g.
Let me know if you have a better idea on how to make this more efficient :)

[fintelia]

I left a couple stylistic suggestions, but the code itself looks good

[fintelia]

As a side note, trying to change the return type to &DynamicImage would cause borrow checker errors in the more common case where the dimensions do not match. There's even fancier ways to work around that, but they would make things harder for end users. Ultimately, I think keeping the types as they are is the right decision.

[VolkerFelix]

As a side note, trying to change the return type to &DynamicImage would cause borrow checker errors in the more common case where the dimensions do not match. There's even fancier ways to work around that, but they would make things harder for end users. Ultimately, I think keeping the types as they are is the right decision.

Yeah, for the return by reference to work, I would have needed to change the common case when the dimensions do not match. I didn't want to go down that way.
Thanks for your explanations :)

[fintelia]

There's now just a small rustfmt issue to resolve:

/home/runner/.cargo/bin/cargo fmt -- --check
Diff in /home/runner/work/image/image/src/dynimage.rs at line 668:
             return self.clone();
         }
         let (width2, height2) =
-        resize_dimensions(self.width(), self.height(), nwidth, nheight, false);
+            resize_dimensions(self.width(), self.height(), nwidth, nheight, false);
 
         self.resize_exact(width2, height2, filter)
     }

[VolkerFelix]

There's now just a small rustfmt issue to resolve:

/home/runner/.cargo/bin/cargo fmt -- --check
Diff in /home/runner/work/image/image/src/dynimage.rs at line 668:
             return self.clone();
         }
         let (width2, height2) =
-        resize_dimensions(self.width(), self.height(), nwidth, nheight, false);
+            resize_dimensions(self.width(), self.height(), nwidth, nheight, false);
 
         self.resize_exact(width2, height2, filter)
     }

Should be fixed now

[fintelia]

Thanks!