Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing clippy warnings #1787

Merged
merged 2 commits into from Sep 10, 2022
Merged

Fixing clippy warnings #1787

merged 2 commits into from Sep 10, 2022

Conversation

gents83
Copy link
Contributor

@gents83 gents83 commented Sep 9, 2022

Fixing clippy warnings:

  • Allowed unused doc comments (not working on extern)
  • Fixing deprecated enum usage in PNG compression

@fintelia
Copy link
Contributor

fintelia commented Sep 9, 2022

Could you also mark CompressionType::Huffman and CompressionType::Rle as deprecated since they now fallback to Fast?

@gents83
Copy link
Contributor Author

gents83 commented Sep 10, 2022

Right! Done :)

@HeroicKatora HeroicKatora merged commit b354376 into image-rs:master Sep 10, 2022
@cycraig cycraig mentioned this pull request Sep 10, 2022
Merged
adamLutPhi
adamLutPhi reviewed Sep 16, 2022
View reviewed changes
Copy link

@adamLutPhi adamLutPhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are Reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamLutPhi adamLutPhi adamLutPhi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gents83 @fintelia @adamLutPhi @HeroicKatora